Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make color card chip size a metadata term & Enhance debug pcv.transform.detect_color_card #1609

Merged
merged 21 commits into from
Nov 11, 2024

Conversation

HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented Oct 17, 2024

Describe your changes
Adds additional contour outlines to the output debug image. This is an attempt to make the tool easier to parameterize when it doesn't run under default settings.

Type of update
Is this a:

  • feature enhancement

Associated issues

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl added enhancement Enhancements to existing features update Updates an existing feature/method labels Oct 17, 2024
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.6 milestone Oct 17, 2024
Copy link

deepsource-io bot commented Oct 17, 2024

Here's the code health analysis summary for commits fe0f508..5e60003. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@HaleySchuhl HaleySchuhl changed the title Enhance debug pcv.transform.detect_color_card Make color card chip size a metadata term & Enhance debug pcv.transform.detect_color_card Oct 23, 2024
@nfahlgren nfahlgren merged commit 1dbebaf into main Nov 11, 2024
5 checks passed
@nfahlgren nfahlgren deleted the enhance_debug_detect_color_card branch November 11, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements to existing features ready to review update Updates an existing feature/method
Projects
Status: Done
3 participants