Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor example code fix #1627

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Minor example code fix #1627

merged 1 commit into from
Nov 15, 2024

Conversation

mlohbihler
Copy link
Contributor

Describe your changes
The example code for updating to version 4 appears to have a small bug. The variable bin_img is not defined before it is used, and the variable bin_mask is unused after defining. Moreover, making the change allows the sample code to run completely.

Type of update
Is this a sample code bug fix.

Associated issues
None

Additional context
None

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

Copy link

deepsource-io bot commented Nov 11, 2024

Here's the code health analysis summary for commits 1dbebaf..b4319fb. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Contributor

@HaleySchuhl HaleySchuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mlohbihler for catching and fixing this!

@HaleySchuhl
Copy link
Contributor

@all-contributors please add @mlohbihler for bug and documentation

Copy link
Contributor

@HaleySchuhl

I've put up a pull request to add @mlohbihler! 🎉

@HaleySchuhl HaleySchuhl added documentation Documentation issues or features bugfix Bug fixes ready to review labels Nov 14, 2024
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.6 milestone Nov 14, 2024
@mlohbihler
Copy link
Contributor Author

Thank you @mlohbihler for catching and fixing this!

@HaleySchuhl No trouble at all! There seems to have been a timeout in the test coverage though, so i can't merge. Can you do so?

@nfahlgren nfahlgren merged commit 31105f6 into danforthcenter:main Nov 15, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug fixes documentation Documentation issues or features ready to review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants