Skip to content

Commit

Permalink
Fix passwordRevisionDate format
Browse files Browse the repository at this point in the history
The `passwordRevisionDate` format was not converted to a valid format understand by the mobile clients.
Fixed this by checking if it's not `null` and then convert the timestamp to a valid format.

Signed-off-by: BlackDex <[email protected]>
  • Loading branch information
BlackDex committed Jan 27, 2025
1 parent 1b46c80 commit fc00b7f
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions src/db/models/cipher.rs
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ impl Cipher {
sync_type: CipherSyncType,
conn: &mut DbConn,
) -> Value {
use crate::util::format_date;
use crate::util::{format_date, validate_and_format_date};

let mut attachments_json: Value = Value::Null;
if let Some(cipher_sync_data) = cipher_sync_data {
Expand Down Expand Up @@ -220,7 +220,7 @@ impl Cipher {
})
.map(|mut d| match d.get("lastUsedDate").and_then(|l| l.as_str()) {
Some(l) => {
d["lastUsedDate"] = json!(crate::util::validate_and_format_date(l));
d["lastUsedDate"] = json!(validate_and_format_date(l));
d
}
_ => {
Expand Down Expand Up @@ -261,6 +261,11 @@ impl Cipher {
type_data_json["uri"] = uris[0]["uri"].clone();
}
}

// Check if `passwordRevisionDate` is a valid date, else convert it
if let Some(pw_revision) = type_data_json["passwordRevisionDate"].as_str() {
type_data_json["passwordRevisionDate"] = json!(validate_and_format_date(pw_revision));
}
}

// Fix secure note issues when data is invalid
Expand Down

0 comments on commit fc00b7f

Please sign in to comment.