Fix Duo Field Names for Web Client #5491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BDvirus
approved these changes
Jan 28, 2025
|
Seems similar to what I had brought up back in October. The admin panel should get renamed as well as I mentioned. |
Thank you. I've added a commit which renames the fields in admin page as well. |
BlackDex
approved these changes
Jan 29, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the web client expects different fields for duo integration.
The changes were introduced in the following commit:
bitwarden/clients@41e1d91#diff-2be3b52c1ad01eac329688bca2644e0aa1f819167ed8a9d52ed57f72e18b8aa8L4
bitwarden/clients@41e1d91#diff-8813d04cfcaad734e34e034e8a85eeb4a528d55aeb52b5c88e6bcbfced9fc260L13
Web client sends different fields to the API (and also receives wrong ones):
clientSecretinstead ofsecretKeyandclientIdinstead ofintegrationKeyI believe, this PR can address this.
When saving:
When loading (Client Id and Client Secret is empty):
