Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update api.py #10

Open
wants to merge 3 commits into
base: tutorial
Choose a base branch
from
Open

Update api.py #10

wants to merge 3 commits into from

Conversation

ri0day
Copy link

@ri0day ri0day commented Feb 9, 2018

when create a new topic ,user's uid is neccessary

@ri0day
Update api.py
450845e 
add creater uid to topics table.
@ri0day
Update test_api.py
45902b2 
using  session during the test, according to prev commit
@ri0day
Update test_api.py
a442bc5 
adjust test order ,prevent celery_test run first.
@danidee10
Copy link
Owner

danidee10 commented Feb 9, 2018 •
edited
Loading

Hi, @ri0day you don't need to update the tests. The test_zelery function was named zelery for a reason. Read the article and you'll understand why (I eventually changed it back to celery after explaining).

Also, you shouldn't use self.session to make the requests for all test cases. because it stores cookies and auth information that you may not want to re-use for some tests.

using a fresh requests object gives us a blank slate with no auth information or cookies attached to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ri0day @danidee10