Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 6.4 LTS #3

Merged
merged 7 commits into from
Apr 19, 2024
Merged

Allow Symfony 6.4 LTS #3

merged 7 commits into from
Apr 19, 2024

Conversation

danielburger1337
Copy link
Owner

Closes #2

@danielburger1337 danielburger1337 added the enhancement New feature or request label Apr 4, 2024
@danielburger1337 danielburger1337 self-assigned this Apr 4, 2024
@danielburger1337
Copy link
Owner Author

@florentdestremau This PR allows Symfony 6.4.

The Unit tests pass, so there shouldn't be a problem since the test suite is quite comprehensive.
I also created a brand new Symfony 6.4 application and everything worked out of the box.

I actually don't have any real Symfony 6.4 applications, so I would be gratefull if you could checkout the PR in your application and let me know if everything works correctly.

composer require danielburger1337/2fa-email@dev-symfony-lts

Otherwise this should be good to merge!

@florentdestremau
Copy link

We are currently implementing the 2FA, that's what prompted the issue in the first place. I will gladly report back in a couple of days, while we roll out and have a check

@florentdestremau
Copy link

The command doesn't install the branch:

$ composer require danielburger1337/2fa-email@dev-symfony-lts

In PackageDiscoveryTrait.php line 376:
                                                                                                                                                                                                                                                
  Could not find a matching version of package danielburger1337/2fa-email@dev-symfony-lts. Check the package spelling, your version constraint and that the package is available in a stability which matches your minimum-stability (stable).  
                                                                                                                                                                                                                                                

@danielburger1337
Copy link
Owner Author

The command doesn't install the branch:

A default composer.json does not allow installing dev branches.

https://getcomposer.org/doc/04-schema.md#minimum-stability

To circumvent this, temporarily add "minimum-stability": "dev" to your composer.json:

{
    "name": "My Project",
    "minimum-stability": "dev",
    ...
}

Alternativly you can add the branch constraint to your composer.json manually and then run the following command:

{
    "name": "My Project",
    "require": {
        "danielburger1337/2fa-email": "dev-symfony-lts",
        ...
    }
    ...
}
composer update danielburger1337/2fa-email -W

The -W means to update the package WITH its dependencies. Depending on your composer.lock, you either have to run the command with or without the flag (most likely you will need it).

@florentdestremau
Copy link

It's been working fine on our side for a week, looks good to me 👍

@danielburger1337 danielburger1337 merged commit 4006da9 into main Apr 19, 2024
6 checks passed
@danielburger1337 danielburger1337 deleted the symfony-lts branch April 19, 2024 23:08
@danielburger1337
Copy link
Owner Author

It's been working fine on our side for a week, looks good to me 👍

Released as v1.1.0

Thank you very much for your suggestion and testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept Symfony 6.* (or 6.4 at least)
2 participants