Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated limitedForm to allow FormOptions to be used #236

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Updated limitedForm to allow FormOptions to be used #236

merged 2 commits into from
Apr 11, 2024

Conversation

fetwar
Copy link
Contributor

@fetwar fetwar commented Apr 10, 2024

  • Added a jsdoc for limitedForm
  • Renamed opts to limitOpts for clarity
  • Added optional argument formOpts which is supplied to openModalForm when called
    • Allows for form options like default values to be supplied when using a limitedForm

@fetwar
Copy link
Contributor Author

fetwar commented Apr 10, 2024

@danielo515

@fetwar
Copy link
Contributor Author

fetwar commented Apr 11, 2024

Have fixed the typo causing build to fail and run the workflow in my fork to ensure it would pass.

Should be all good to go now

@danielo515 danielo515 merged commit 9ac9049 into danielo515:master Apr 11, 2024
2 checks passed
@danielo515
Copy link
Owner

thanks @fetwar

@fetwar fetwar deleted the patch-1 branch April 16, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
run-sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fetwar @danielo515