Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow decimal inputs for number fields #237

Merged

Conversation

fetwar
Copy link
Contributor

@fetwar fetwar commented Apr 16, 2024

Bugfix for #186

Sets the HTML input property step to any when field type is number - allowing non-whole numbers to be input.

This aligns the frontend visual feedback to the user with the backend validation, which would previously let inputs through, but apply CSS rules for invalid input.


Would be nice to have this configurable in the modal form editor as a future enhancement, along with min and max attributes.

@danielo515
Copy link
Owner

@fetwar do you mind re-wording your commit message to read like:
fix: allow decimal inputs for number fields
That is the only way the automatic deploy and changelog will pick it up.

@fetwar
Copy link
Contributor Author

fetwar commented Apr 17, 2024

No problem, will do

@fetwar fetwar force-pushed the bugfix/numbers-not-accepting-decimals branch from 526bcc8 to ccc0b53 Compare April 18, 2024 01:15
@fetwar
Copy link
Contributor Author

fetwar commented Apr 18, 2024

@danielo515 I have pushed the commit message amendment, no content changes from the PR previously.

... just realised I used a capital letter and you didn't in your advised PR message. If this is an issue let me know and I will amend again lol

@danielo515 danielo515 merged commit b70e99a into danielo515:master Apr 20, 2024
2 checks passed
@danielo515
Copy link
Owner

Thank you @fetwar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants