fix: set initial value of fixed-source select fields, if provided #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the initial value provided by the user does not match the field's options, the field's value will be blank (previously, the first option would be selected by default).
|
This would partially resolve #227 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple fix allows an initial/default value to be set for
selecttype fields withfixedsource (i.e., drop-down option lists). I believe this classes as a fix, as the readme gives the impression that default values should be generally applicable.I'm not aware of any downsides to this. If the initial value provided by the user does not match the field's options, the field's value in the constructed form will simply be blank (""). Previously, the first option would always be selected by default.