-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/image-input #337
Feat/image-input #337
Conversation
Can we make that i can import any file not just image? Just let it general file picker, regardless what the file is. Thank you for implementation! The modal form is top10 obsidian plugin! |
I would prefer to have a separate input for that. I want to provide the best user experience, and the images deserve special treatment IMO. |
If this is the case, you should provide more functionality for this, like image optimization, convert it to jpg, change resolutions, etc.. in this case the separated modal make sense. |
@dxcore35 that could be done in the future, indeed, and the easiest way to pave that road is by starting it as a separate thing. Do you mind opening a new issue detailing your expectations for the generic attachments? |
This adds a new input specific for images.
This will import the image into your vault and give you a reference to the generated TFile
Fixes #241 (at least for images)