feat: scroll to new fields in the editor

.github/workflows/pull-request.yml

@@ -0,0 +1,17 @@
+name: Build and Test
+on:
+    pull_request:
+
+jobs:
+    build:
+        runs-on: ubuntu-latest
+        steps:
+            - uses: actions/checkout@v3
+            - name: Use Node.js
+              uses: actions/setup-node@v3
+              with:
+                  cache: "npm"
+
+            - run: npm install
+            - name: Build and Test
+              run: npm run build && npm run test

package.json

@@ -5,8 +5,8 @@
     "main": "main.js",
     "scripts": {
         "dev": "node esbuild.config.mjs",
-        "build": "tsc -noEmit -skipLibCheck && node esbuild.config.mjs production",
-        "check": "tsc --noEmit",
+        "build": "npm run check && node esbuild.config.mjs production",
+        "check": "svelte-check --tsconfig tsconfig.json",
         "test": "jest",
         "version": "node version-bump.mjs && git add manifest.json versions.json"
     },
@@ -25,6 +25,7 @@
         "jest": "^29.7.0",
         "obsidian": "^1.4.11",
         "svelte": "^4.2.0",
+        "svelte-check": "^3.5.2",
         "svelte-preprocess": "^5.0.4",
         "ts-jest": "^29.1.1",
         "ts-node": "^10.9.1",
@@ -35,4 +36,4 @@
         "fuse.js": "^6.6.2",
         "valibot": "^0.19.0"
     }
-}
+}

src/core/formDefinition.ts

@@ -1,4 +1,4 @@
-import { object, number, literal, type Output, is, array, string, union, optional, safeParse, minLength, toTrimmed, flatten } from "valibot";
+import { object, number, literal, type Output, is, array, string, union, optional, safeParse, minLength, toTrimmed } from "valibot";
 /**
  * Here are the core logic around the main domain of the plugin,
  * which is the form definition.
@@ -32,7 +32,7 @@ const InputSelectFixedSchema = object({
     type: literal("select"),
     source: literal("fixed"),
     options: array(object({
-        value: nonEmptyString('Value of a select option'), label: string()
+        value: string([toTrimmed()]), label: string()
     }))
 });
 
@@ -170,7 +170,10 @@ export function validateFields(fields: unknown) {
     }
     console.error('Fields issues', result.issues)
     return result.issues.map(issue =>
-        ({ message: issue.message, path: issue.path?.map(item => item.key).join('.') })
+    ({
+        message: issue.message, path: issue.path?.map(item => item.key).join('.'),
+        index: issue.path?.[0]?.key ?? 0
+    })
     );
 }
 

src/views/EditFormView.ts

@@ -46,7 +46,6 @@ export class EditFormView extends ItemView {
             target: this.containerEl,
             props: {
                 definition: this.formState,
-                app: this.app,
                 onChange: () => {
                     console.log(this.formState)
                     this.app.workspace.requestSaveLayout()