Merge pull request #95 from danielwestendorf/fix-93

Replace meta passed filename extension
danielwestendorf · Feb 22, 2020 · 164f5f1 · 164f5f1
2 parents d17bc84 + 93f81f4
commit 164f5f1
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/lib/render.js b/lib/render.js
@@ -35,7 +35,7 @@ module.exports = class Render {
   }
 
   filename() {
-    return `${this.meta().filename || uuid()}.pdf`
+    return `${(this.meta().filename || uuid()).split('.')[0]}.pdf`
   }
 
   printOptions() {

diff --git a/test/lib/render-test.js b/test/lib/render-test.js
@@ -1,7 +1,7 @@
 const assert = require('assert')
 let Render
 
-const htmlString = `
+let htmlString = `
   <html>
     <head>
       <meta name='breezy-pdf-filename' content='fancyfilename'/>
@@ -48,6 +48,20 @@ module.exports = {
 
     notSpecified() {
       assert(new Render('').filename().match(/\.pdf$/))
+    },
+
+    alreadyHasExtension() {
+      htmlString = `
+        <html>
+          <head>
+            <meta name='breezy-pdf-filename' content='fancyfilename.pdf'/>
+          </head>
+          <body>
+          </body>
+        </html>
+      `.trim()
+
+      assert.equal('fancyfilename.pdf', new Render(htmlString).filename())
     }
   }
 }