Test on Ruby 3.2 and 3.3 #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danini-the-panini
approved these changes
Feb 26, 2024
|
The fails are because bundler isn't installing on Ruby 2.x versions. All of Ruby 2.x is very EOL now, so I could remove it and Mittsu goes Ruby 3 only? Or, if you want to keep supporting 2.x, we should find a way to get those builds working with an older version of bundler. |
|
Could we just add the gem install bundler version to the workflow? |
|
Probably yes. I'll have a look. |
|
Having a go at fixing builds in #124 |
|
#124 fixes the builds generally, so once that's merged in I'll update this one to go on top. |
Floppy
force-pushed
the
test-more-rubies
branch
from
2e568e9
to
15b93b2
Compare
Floppy
force-pushed
the
test-more-rubies
branch
from
15b93b2
to
f035250
Compare
|
All green! Side note, I love how fast these builds are now! |
danini-the-panini
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.