-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split mittsu gem into mittsu-core and mittsu-renderer-opengl #125
Split mittsu gem into mittsu-core and mittsu-renderer-opengl #125
Conversation
a64f5e1
to
e5e179e
Compare
Would we do this in subfolders, like Rails does? |
Also is this a patch or minor version bump, since it doesn't really change the interface |
Yeah, subfolders is probably a good idea. And you right, technically by semver it would be a patch version, as absolutely nothing would change! Hah. |
Sorry, I never got much further on this. Hopefully I can come back to it soon. |
287e0f9
to
772b958
Compare
@danini-the-panini I think this is ready for you to take a look at. I've split it into separate folders rails-style, and there is a top-level
I'm having trouble running the examples (because of #130), so I can't actually see anything, but the tests seem good; although, I can't tell if coverage upload is still working. |
OK, after rebasing #131, the examples now run, which is great! |
772b958
to
ed8d682
Compare
This is going to cause some nonsense now, since according to gem naming conventions, Considering Mittsu is pre-1.0, we can still reasonably introduce breaking changes in a minor version bump, and I think in this case it is warranted. I'm going to split out the opengl renderer into its own gem and keep As for the opengl renderer, I'm going to move it to its own repo entirely. |
Makes sense to me! |
I think that complete separation is a cleaner approach than what I've tried to do here with keeping compatibility and repo structure, so I'm 100% on board. Feel free to take anything useful from what I've done here, but also just throw it away if it's easier :) |
This is an early PR for my attempt to resolve #115 by splitting mittsu into two gems. I think it can all be done in the same repo, and I've made it so that
mittsu
gem itself simply depends on the two component parts.I've kept a single version string, and made them depend on that exact version, to avoid any differences causing problems. Can always be split later on.
Resolves #115