wrap the raw notcurses pointer to ensure proper dropping order #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace `Notcurses`' `into_ref` and `into_ref_mut` functions with `with_nc` and `with_nc_mut`. - remove the `impl From<NcPlane> for Plane`, and replace it with the `from_ncplane` method. - update the signature of methods that doesn't require a mutable reference to `Notcurses`. - update `Notcurses`, `Plane`, `Visual` `Statistics` and `Palette`.
- update `Notcurses`: - store `NotcursesInner` wrapping the raw pointer. - move proper shutdown functionality to `NotcursesInner`. - update `Plane`: - store a cloned reference to `NotcursesInner`.
- store a cloned reference to `NotcursesInner` in `Visual`. - require a new `Notcurses` argument in `VisualBuilder` methods: `build_from_rgba`, `build_from_rgb`, `build_from_rgbx`, `build_from_bgra`, `build_from_file`, `build_from_sixel`, `build_from_palidx`. - require a new `Notcurses` argument in `Visual` methods: `from_rgba`, `from_rgb`, `from_rgbx`, `from_bgra`, `from_file`. - update visibility `Notcurses.options` and `Plane.notcurses`. - update example `visual`.
- update `Plane` methods to only require a shared reference to `Notcurses`: `from_cli`, `new_at`, `new_sized`, `new_sized_at`. - update examples: `visual`, `hello-world`, `cli`, `info`, `input` and the one in the readme.
joseluis
force-pushed
the
feature-rc-refcell
branch
from
8d41da2 to
a29fd47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*mut Ncpointer as a field of the newNotcursesInner.Rc<RefCell<NotcursesInner>>as a field ofNotcurses.Plane.Dropimpl toNotcursesInner.fixes #8