Support for IE and Firefox #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more editor support
Fixed spelling error in the word "appearance".
Added "space-around" option to Justification.
Fixed minor spelling error.
Fixed CSS typos in FlexPropertyHelper.
Added missing ensureInjected calls.
Changed mgwt to work with GWT 2.7
flex-direction property is set using setOrientation.
Replaced flex-flow with flex-direction
This restores compatibility with GWT 2.6, where HasText came from AutoDirectionHandler.Target. Note that this reverts 3fd1752 again.
Add HasText to the implemented interfaces of MValueBoxBase
fix for emulated icon handling.
We call setPointerCapture on the element that receives the pointer down event. Added FlexPropertyHelper enhancements to support IE10
causes the IE10 browser to disappear behind other windows
ie10 sets shrink to 0 by default if not specified whereas webkit sets it to 1. Do not do event.preventDefault in the CellList if we are running on windows phone, prevents the scroll panel the CellList is in scrolling properly.
capture, input elements failed to get the focus properly. See https://stackoverflow.com/questions/27355271/desktop-ie10-ie11-on-windows-input-elements-fail-to-get-focus-when-pointer-cap
issues, so we no longer capture pointer events if the target element is an input or textarea. Turned on default behaviour for textarea so we can scroll textarea. However this can cause a bounce when scrolling a text area to the start or end. However this is better then not being able to scroll at all like currently in IOS
but worked fine on windows phone 8. Had to force getComputedStyle to return a 3D matrix for the transform property by specifying a non-zero z value (-1px). We now detect the device density correctly for ie10/11 (we use the screen object). We do not try and detect ie11 user agent, we assume if using ie11 that the meta tag ie10 compatibilty is set. User agent strings for ie11 are now even more complex. They specify webkit, iphone, gecko etc etc as part of the string. This makes OS detection more difficult using the user agent string.
Mozilla implementation of FlexInputHelper
touch handlers added that do not always give you the required behaviour
!important to portraitonly and landscapeonly css since not always easy to ensure this css gets priority over other css
any diferrence. Looks like you have to specify in the html file as a meta tag and not rely on it being dynamically added and picked up by ie10/11
amount of DOM added, attempting to eliminate any translate3d type issues. Use 0px instead of -1px for the z co-ordinate and check what transform matrix returned, either 2d or 3D and extract the relevant co-ordinates
to use native scrollable divs to get better performance then using the MGWT ScrollPanel. Unfortunately one side effect of this is we start to get application bounce when scrolling limits are reached of a scrollbale div.
of orientation handler if current orientation handler not removed correctly. Remove the orientation handler correctly when orientation event fired.
When preventing scrolling for IOS we no longer preventDefault the TouchMove event if it originates from an INPUT, TEXTAREA or SELECT element. This solves a multitude of issues with these input types where default behaviour of the browser is required so that they function as expected. Also on more sensitive touch devices like the ipad air 2 the input type elements were very hard to tap and navigate between if a TouchMove event was generated as part of the touch and the TouchMove vent is prevent defaulted.
Conflicts: pom.xml src/main/java/com/googlecode/mgwt/ui/client/widget/animation/bundle/dissolve.css src/main/java/com/googlecode/mgwt/ui/client/widget/animation/bundle/fade.css src/main/java/com/googlecode/mgwt/ui/client/widget/animation/bundle/flip.css src/main/java/com/googlecode/mgwt/ui/client/widget/animation/bundle/pop.css src/main/java/com/googlecode/mgwt/ui/client/widget/animation/bundle/slide-up.css src/main/java/com/googlecode/mgwt/ui/client/widget/animation/bundle/slide.css src/main/java/com/googlecode/mgwt/ui/client/widget/animation/bundle/swap.css src/main/java/com/googlecode/mgwt/ui/client/widget/animation/impl/animation-display.css src/main/java/com/googlecode/mgwt/ui/client/widget/button/imagebutton.css src/main/java/com/googlecode/mgwt/ui/client/widget/dialog/panel/dialog.css src/main/java/com/googlecode/mgwt/ui/client/widget/input/checkbox/checkbox.css src/main/java/com/googlecode/mgwt/ui/client/widget/input/search/searchbox.css src/main/java/com/googlecode/mgwt/ui/client/widget/main/main.css src/main/java/com/googlecode/mgwt/ui/client/widget/progress/progressindicator.css src/main/java/com/googlecode/mgwt/ui/client/widget/progress/progressspinner.css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see another request #62 in there but in this one I mainly concentrated on CSS animations and updates so Firefox and IE are supported, up to Windows 7. This would be complementary to what I saw there.
Most animations work in IE. Firefox has an issue with some buttons but is functional.