forked from openframeworks/openFrameworks
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vulkan Renderer openFrameworks #7
Open
danoli3
wants to merge
547
commits into
danoli3:master
Choose a base branch
from
openframeworks-vk:vk
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ this variable is only used when processing draw commands, and is now exclusively local to that method
+ add generator for transient command buffer
+ more elegant camera handling +inline L mesh creation
+ stageData returns a tuple of copyInstructions, static mesh this is not as elegant as it can be ideally this method is simpler-and one-purpose only.
+ refactor to 'deferred initialisation' pattern. This adds a Settings object to Texture, which will initialise to sane defaults. Settings can then be modified, and Texture can be allocated/setup using `Texture::setup(settings)`. I'm not 100% happy with this pattern, as it does not allow us to auto-destroy internal vk objects, but it makes parameters more discoverable, and reduces verbosity in application code.
+ update examples to new texture initialisation api
+ fixes an issue with pipeline barriers not using the correct access, and pipeline stage masks: memory and pipeline stage masks must be compatible.
+ allocate and begin associated command buffer in constructor - this allows us more flexibility with renderBatches
+ add helper methods to set values for commonly used blendmodes - alpha, premultiplied alpha, screen
+ add missing initialisers for default subpass in renderer + refactor pipelineLayout creation in shader.cpp
…orks into v3 manually fixed conflicts in: libs/openFrameworks/app/ofAppGLFWWindow.h libs/openFrameworks/app/ofAppRunner.cpp added std:: in `vkRenderer` header files, and `using namespace std` cpp files.
+ merge latest of/master + catch swapchain out-of-date message received from nvidia driver upon window resize + fixes to placate latest gcc
danoli3
pushed a commit
that referenced
this pull request
Nov 5, 2024
danoli3
force-pushed
the
master
branch
5 times, most recently
from
January 15, 2025 05:52
f183980
to
53578e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/openframeworks-vk/openFrameworks
https://poniesandlight.co.uk/reflect/of-vulkan-renderer-update/