Skip to content

Commit

Permalink
Upgrade symfony/amqp-messenger to 6.3.12 for php-amqp 2 compatibility
Browse files Browse the repository at this point in the history
The php-amqp extension has been upgraded from v1 to version 2 on
several platforms - Platform.sh and our Docker images. This update
introduces breaking changes which causes problems with the
symfony/amqp-messenger package.

Ack() and Nack() functions are expected to return booleans but now no
longer return any value. This causes type errors to be thrown:

Symfony\Component\Messenger\Bridge\Amqp\Transport\Connection::ack(): Return
 value must be of type bool, null returned

To address this we could either downgrade the version of the php-amqp
extension to v1 but we do not have easy control over all platforms.
Consequently we go for an upgrade to ensure compatibility instead.

symfony/amqp-messenger is fully compatible with php-amqp from 6.3.12
and onwards but there is no easy way to update all three applications
to Symfony 6.3 without causing other problems raised by our CI checks.

In an attempt to address the problem we only upgrade
symfony/amqp-messenger to 6.3.12.

We do not know if bumping individual packages will cause problems but
tests so far have shown that not to be the case.
  • Loading branch information
kasperg committed May 10, 2024
1 parent 0edb1c8 commit f94fe12
Show file tree
Hide file tree
Showing 6 changed files with 26 additions and 26 deletions.
2 changes: 1 addition & 1 deletion cover-api/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"predis/predis": "^1.1",
"ruflin/elastica": "^7.1",
"sensio/framework-extra-bundle": "^6.2",
"symfony/amqp-messenger": "6.1.*",
"symfony/amqp-messenger": "~6.3.12",
"symfony/asset": "^6.1",
"symfony/console": "^6.1",
"symfony/dotenv": "^6.1",
Expand Down
16 changes: 8 additions & 8 deletions cover-api/composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion importers/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"predis/predis": "^2.0",
"prinsfrank/standards": "^1.3",
"scriptotek/marc": "^2.1",
"symfony/amqp-messenger": "^6.1",
"symfony/amqp-messenger": "~6.3.12",
"symfony/cache": "^6.1",
"symfony/console": "^6.1",
"symfony/doctrine-messenger": "^6.1",
Expand Down
16 changes: 8 additions & 8 deletions importers/composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion upload-api/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"nelmio/cors-bundle": "^2.2",
"predis/predis": "^2.0",
"sensio/framework-extra-bundle": "^6.2",
"symfony/amqp-messenger": "6.1.*",
"symfony/amqp-messenger": "~6.3.12",
"symfony/asset": "6.1.*",
"symfony/cache": "6.1.*",
"symfony/console": "6.1.*",
Expand Down
14 changes: 7 additions & 7 deletions upload-api/composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit f94fe12

Please sign in to comment.