Ensure vendors use UTC timezone for sources #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the image validator service tries to determine if a cover image has been updated it tries to compare last-modified values for source and image. The default image validator will use UTC by default for images but sources are created with whatever timezone is configured in the environment. If these do not match then images will be considered updated even though they are not. To ensure that sources are generated with the same timezone no matter what has been configured in the environment we hardcode source dates to also use UTC. An alternate approach would be to make it a configurable variable but that would be a more complex change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the image validator service tries to determine if a cover image has been updated it tries to compare last-modified values for source and image.
The default image validator will use UTC by default for images but sources are created with whatever timezone is configured in the environment. If these do not match then images will be considered updated even though they are not.
To ensure that sources are generated with the same timezone no matter what has been configured in the environment we hardcode source dates to also use UTC.
An alternate approach would be to make it a configurable variable but that would be a more complex change.