More timezone fixes #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3cf0bca.
We need timezones to be the same across all elements of the application. Doctrine requires the same timezone to be used when saving and loading dates. https://www.doctrine-project.org/projects/doctrine-orm/en/2.19/cookbook/working-with-datetime.html#default-timezone-gotcha If timezones are different then the system will not be able to identify a cover file as being unchanged because the modified time might be different. Consequently we need to avoid setting the timezone explicitly whereever possible.
kasperg
force-pushed
the
more-timezone-fixes
branch
2 times, most recently
from
3144659 to
21f4a3c
Compare
We do not have the same access to PHP.ini through all development and production environments. Consequently we set this in the application kernel instead.
kasperg
force-pushed
the
more-timezone-fixes
branch
from
21f4a3c to
bd1fa3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.