GitHub actions restructure #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes the pull request template and GitHub Actions workflows For workflows each of the files is moved. GitHub Actions does not support subfolders for workflows so each file is also renamed with the subproject prefix separated by _. For the pull request template we just move one of the files and delete the others.
Each of them were designed to run in their own subprojects but are now placed in the project root. Specify the project subdirectory according to each workflow.
This makes it a lot easier to spot where any errors might be located.
Otherwise setup-node will not be able to locate the lock file and fail.
We have updated the application to use OpenSearch instead of ElasticSearch in practice. We should update tests and GitHub Actions accordingly.
The OpenSearch client will throw exceptions on errors.
That is what OpenSearch returns.
kasperg
force-pushed
the
github-actions-restructure
branch
from
40837b7 to
843465c
Compare
kasperg
force-pushed
the
github-actions-restructure
branch
from
62974e1 to
f1b1e11
Compare
This should prevent PHP CS Fixer from erroring.
Ensure that search index always gets an integer as error code. Strip all implementation from SAXO service. It previously has references to class constants and the like from parent code that has been removed when it was deprecated. Remove most of the the entire implementation to bring it inline with other deprecated vendors.
kasperg
force-pushed
the
github-actions-restructure
branch
from
dbbf9c7 to
c074cd2
Compare
For whatever reason PHPUnit will not run through the bridge in GitHub Actions after the subprojects have been joined. Try to use PHPUnit directly instead to fix this. This way the Upload API uses the same approach as in the other projects.
This way we avoid using time and ressources for unneeded checks.
There does not seem to be any meaningful difference between the two workflows so we might as well consolidate them. PHP CS Fixer will error on PHP versions newer than 8.1 - perhaps because of the configuration in composer.json. Use PHP_CS_FIXER_IGNORE_ENV=1 to ignore these errors. It should not be the responsibility of this to to verify this anyway.
kasperg
force-pushed
the
github-actions-restructure
branch
from
93b09f6 to
08d1f50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.