Speed up ci:reset by passing along a pre-built DB. #1629
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasben
force-pushed
the
speed-up-ci-reset
branch
from
9868b68 to
2eb1770
Compare
rasben
force-pushed
the
speed-up-ci-reset
branch
from
2eb1770 to
262d9f3
Compare
rasben
force-pushed
the
speed-up-ci-reset
branch
from
d1af573 to
bfc848e
Compare
rasben
force-pushed
the
speed-up-ci-reset
branch
from
bfc848e to
70aa795
Compare
rasben
force-pushed
the
speed-up-ci-reset
branch
from
70aa795 to
21428b9
Compare
rasben
force-pushed
the
speed-up-ci-reset
branch
from
21428b9 to
a466ef2
Compare
rasben
force-pushed
the
speed-up-ci-reset
branch
from
a466ef2 to
5c688e2
Compare
spaceo
reviewed
Oct 9, 2024
| @@ -382,7 +386,9 @@ tasks: | |||
| ci:reset: | |||
| desc: Create CI setup in a clean state | |||
| cmds: | |||
| - task dev:reset | |||
| - task dev:reset:common | |||
| - task dev:cli -- drush sqlq --file=../tools/site-reset.sql.gz | |||
There was a problem hiding this comment.
What is contained in site-reset.sql.gz?
It would be nice if it was documented somewhere what is happening here
| @@ -125,8 +125,8 @@ tasks: | |||
| cmds: | |||
| - docker compose {{ .DOCKER_COMPOSE_FILES }} pull | |||
|
|
|||
| dev:reset: | |||
| desc: Create local development setup in a clean state | |||
| dev:reset:common: | |||
There was a problem hiding this comment.
What is the purpose of dev:reset:common? Would be nice to have in the description what the intention is.
Also consider which of the newly introduced dev:rest* cmds private so it is clear what is meant to be run as seprate task cmds and what is used internally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up the CI actions, spending ~2 minute instead of ~4 minutes on just setting up the basic site.
Ideally, we could speed it up even more by somehow caching the result of
docker compose {{ .DOCKER_COMPOSE_FILES }} pull, but I could not get it working.If we managed to get that working, I think we could get it all the way down to 30 seconds.