Improve dev https setup #1882
Merged
Improve dev https setup #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can tell Lagoon to ignore the `https` service with a label, so we don't need a separate file.
If you run a docker compose old enough to not define COMPOSE_PROJECT_NAME, you're going to run into a whole lot of other problems anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
httpsservice intodocker-compose.ymland tell Lagoon to ignore it. Remove and clean up afterdocker-compose.dev.yml.Drop defaulting
COMPOSE_PROJECT_NAMEsporadically. It should be used everywhere to make sense, but we wouldn't want to pretend to support a docker compose so old that it doesn't define the variable.