Ddfher 145 dev setup adjustments #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GraphQL credentials for GO and BNF has been split up for safety. It's hardcoded as it already is in dpl_consumers. Ref DDFHER-145
Ref DDFHER-145
It needs to be settable in the bootstrap of development sites. Ref DDFHER-145
xendk
force-pushed
the
ddfher-145-dev-setup-adjustments
branch
from
cb0022a to
8a3a60e
Compare
rasben
reviewed
Jan 9, 2025
web/modules/custom/bnf/bnf_client/config/install/bnf_client.settings.yml But it'll get overridden by the docker setup when I get to https://reload.atlassian.net/browse/DDFHER-186 |
rasben
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFHER-161
Description
Fixes BNF to use the new GraphQL creds, and makes BNF server URL configurable.