Add category term name as notice in opening hours legacy API #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Redia app requires opening hours to have a category for them to be displayed. Currently we only return the category id. However new categories are not likely to be the same as previously. Also we do not provide an API for exposing categories with their ids and titles. To address this in a simple way we add the category name as a notice for each instance. It turns out that the Redia app will display opening hours with the notice if the notice is defined no matter what the category id is. Consequently this is a rather simple way to communicate the information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFHER-177
Description
The Redia app requires opening hours to have a category for them to be displayed. Currently we only return the category id. However new categories are not likely to be the same as previously. Also we do not provide an API for exposing categories with their ids and titles.
To address this in a simple way we add the category name as a notice for each instance.
It turns out that the Redia app will display opening hours with the notice if the notice is defined no matter what the category id is. Consequently this is a rather simple way to communicate the information.