Ddfher 186 bnf dev setup #1970
Ddfher 186 bnf dev setup #1970
Conversation
xendk
force-pushed
the
ddfher-186-bnf-dev-setup
branch
from
8f70305 to
c1ee534
Compare
xendk
force-pushed
the
ddfher-186-bnf-dev-setup
branch
from
c1ee534 to
806c7ae
Compare
xendk
force-pushed
the
ddfher-186-bnf-dev-setup
branch
from
806c7ae to
57cb52b
Compare
There was a problem hiding this comment.
I both like and dislike the approach taken here :)
At one point I think it solves the problem of managing the two sites in develop nicely.
At another point we keep on bragging about the genius idea about using the same Drupal instance for dpl-cms and bnf and the automatic benefits - which I agree upon.
But here we have two docker compose files that are almost identical and we have two settings.php files. And as far as I see it, there is quite a big risk that we forget something maintaining it in the future
| dev:bnfcli: | ||
| summary: dev:cli for BNF site, a noop if BNF not enabled | ||
| status: | ||
| - "[[ -z \"{{ .DOCKER_COMPOSE_FILES_BNF}}\" ]]" |
There was a problem hiding this comment.
I think it would be nice with and error to the end user if BNF is not enabled when using this cmd.
There was a problem hiding this comment.
And I can see now it is because you use it internally in the Taskfile. The thing is that we use "dev:cli" directly quite a lot in our team. So, as it is with these changes, if we call task dev:bnfcli nothing would happen and the developer would not know why, right?
There was a problem hiding this comment.
Well, task prints "bnfcli is up-to-date". Not ideal, but if you're in a position where you actually use the task, you'll we aware of this quirk.
assets/sites.php
Outdated
| $host = $_SERVER['HTTP_HOST']; | ||
| if (preg_match('/^bnf-/', $host)) { | ||
| $sites[$host] = 'bnf'; | ||
| } |
There was a problem hiding this comment.
I think this prefix rule should be documented somewhere so people know it.
xendk
force-pushed
the
ddfher-186-bnf-dev-setup
branch
from
57cb52b to
f9bf216
Compare
BNF will need to optionally spin two sites up in the local docker setup, and this makes it simpler. Ref DDFHER-186
Ref DDFHER-186
Ref DDFHER-186
xendk
force-pushed
the
ddfher-186-bnf-dev-setup
branch
from
f9bf216 to
2f5a1cc
Compare
Link to issue
https://reload.atlassian.net/browse/DDFHER-186
Description
Add setup for running both a CMS and a BNF site in one environment.