Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "go_linkbox" paragraph type to go_paragraphs #1974

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Add "go_linkbox" paragraph type to go_paragraphs #1974

merged 4 commits into from
Jan 16, 2025

Conversation

kasperbirch1
Copy link
Contributor

@kasperbirch1 kasperbirch1 commented Jan 14, 2025 •
edited
Loading

Base automatically changed from DDFBRA-325-go-article to develop January 15, 2025 13:14
@kasperbirch1 kasperbirch1 force-pushed the DDFBRA-344--paragraph-linkbox branch from 4d5e055 to d0e3309 Compare January 15, 2025 15:21
@spaceo spaceo self-requested a review January 16, 2025 09:56
@spaceo spaceo removed their assignment Jan 16, 2025
spaceo
spaceo reviewed Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@spaceo spaceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please ellaborate over why we need these sepearate fields for Go instead of reusing existing:
field_go_link
field_go_description
field_go_image (is it because we need special handling/sizes of the image?)

@kasperbirch1
Copy link
Contributor Author

kasperbirch1 commented Jan 16, 2025 •
edited
Loading

Could you please ellaborate over why we need these sepearate fields for Go instead of reusing existing: field_go_link field_go_description field_go_image (is it because we need special handling/sizes of the image?)

@spaceo
That's because there were no generic fields, they were specific, such as field_hero_image, etc.

@kasperbirch1 kasperbirch1 requested a review from spaceo January 16, 2025 11:58
spaceo
spaceo approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@spaceo spaceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kasperbirch1 kasperbirch1 merged commit e9e09ec into develop Jan 16, 2025
40 checks passed
@kasperbirch1 kasperbirch1 deleted the DDFBRA-344--paragraph-linkbox branch January 16, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaceo spaceo spaceo approved these changes

Assignees

@Dresse Dresse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kasperbirch1 @spaceo @Dresse @dpl-platform-bot