Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDFBRA-348 - Fix event visibility in Event list - automatic+ Premature "expiration" label on events #1987

Conversation

kasperbirch1
Copy link
Contributor

@kasperbirch1 kasperbirch1 commented Jan 20, 2025

Link to issue

https://reload.atlassian.net/browse/DDFBRA-348

Description

Fixed an issue where active events (with future end dates) were not properly displayed in the Event list - automatic paragraph.

Also corrected a bug where events were marked as "expired" prematurely.

Test

https://varnish.pr-1987.dpl-cms.dplplat01.dpl.reload.dk/test-eventlist-dans

image image

Events should remain visible while they are active, so we now check the end date instead.
- Replaced `DrupalDateTime('today')` with `DrupalDateTime('now')` to prevent issues caused by `today` defaulting to `00:00`.
The database operates in UTC, so we must explicitly set the correct timezone.
Copy link
Contributor

@Dresse Dresse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
We talked about adding some testing for events during Standup, but I can't remember what we decided. I guess it can also come at later point if necessary.

@Dresse Dresse assigned kasperbirch1 and unassigned kasperg, spaceo and Dresse Jan 22, 2025
@kasperbirch1 kasperbirch1 removed their assignment Jan 22, 2025
@kasperbirch1 kasperbirch1 merged commit 735adeb into develop Jan 28, 2025
36 checks passed
@kasperbirch1 kasperbirch1 deleted the DDFBRA-348-eventlist-kan-ikke-vise-arrangementer-der-straekker-sig-over-flere-dage branch January 28, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants