-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go linkbox v2 #2030
Merged
Merged
Go linkbox v2 #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40f664f
to
5dc50ea
Compare
5dc50ea
to
1a27de8
Compare
The GO team requested an optional `aria-label` for accessibility improvements.
Enabled support for `aria-label`, fixed a typo in the link label, and reordered fields to place the description above the link.
…`go_category` This change streamlines the use of colors in the Go project. Unfortunately, we cannot reuse fields between paragraph types and normal content types.
1a27de8
to
a1d53ad
Compare
Removed `LinkitGoOptionsWidget` due to difficulties in exporting extra fields to GraphQL. Instead, implemented a `go_link` paragraph with a URL (title included), an `aria-label`, and a "opens in new window" toggle. This is now used in `go_linkbox` and enabled in GraphQL
1d75b68
to
044ee64
Compare
Dresse
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! I only have a few comments. Otherwise 👍
value: content_color_4 | ||
label: 'Content Color 4' | ||
- | ||
value: content_color_5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only think 4 different colours are gonna be used, so we should limit the colours to 4 options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFBRA-430
https://reload.atlassian.net/browse/DDFBRA-431
Description
This pull request replaces the existing
go_color
(color picker) with anoptions_select
(dropdown)Additionally, it introduces the "DPL Linkit with GO Options" widget and refactors go_linkbox to use it, ensuring better accessibility and maintainability.Due to accessibility via GraphQL, I have introduced the
go_link
as a paragraph instead. This can be accessed through GraphQL and does not introduce new concepts into the project.Test
https://varnish.pr-2030.dpl-cms.dplplat01.dpl.reload.dk/node/29/edit
https://varnish.pr-2030.dpl-cms.dplplat01.dpl.reload.dk/admin/config/graphql/servers/manage/graphql_compose_server/explorer
GraphQL:
Result: