Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/advanced search #395

Conversation

Adamik10
Copy link
Contributor

@Adamik10 Adamik10 commented Oct 2, 2023

Link to issue

https://reload.atlassian.net/browse/DDFSOEG-533

Description

In this PR we add the advanced search app, it's data props, and update the dpl-design-system, and dpl-react libraries.

Screenshot of the result

Checklist

  • My complies with our coding guidelines.
  • My code passes our static analysis suite. If not then I have added a comment explaining why this change should be exempt from the code standards and process.
  • My code passes our continuous integration process. If not then I have added a comment explaining why this change should be exempt from the code standards and process.

Additional comments or questions

The libraries still need to be properly updated when the PRs in dpl design system and dpl-react are approved and merged in.

@spaceo
Copy link
Collaborator

spaceo commented Oct 9, 2023

@Adamik10 Cypress is failing:
image

@Adamik10 Adamik10 force-pushed the feature/advanced-search branch from 9cca5c2 to 9d81968 Compare October 9, 2023 07:48
@Adamik10
Copy link
Contributor Author

Adamik10 commented Oct 9, 2023

Follow this PR in a new PR ( #400 )

@Adamik10 Adamik10 closed this Oct 9, 2023
@github-actions github-actions bot temporarily deployed to pr-401 October 9, 2023 08:15 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants