Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create environment for testing: DDFLSBP-192 (Align Reservation Change) #413

Merged
merged 12 commits into from
Oct 17, 2023
Merged

Create environment for testing: DDFLSBP-192 (Align Reservation Change) #413

merged 12 commits into from
Oct 17, 2023

Conversation

kasperbirch1
Copy link
Contributor

@kasperbirch1 kasperbirch1 commented Oct 12, 2023 •
edited
Loading

Link to issue

danskernesdigitalebibliotek/dpl-react#574

Description

Please include a short description of the suggested change and the reasoning behind the approach you have chosen.

Screenshot of the result

If your change affects the user interface you should include a screenshot of the result with the pull request.

Checklist

  • My complies with our coding guidelines.
  • My code passes our static analysis suite. If not then I have added a comment explaining why this change should be exempt from the code standards and process.
  • My code passes our continuous integration process. If not then I have added a comment explaining why this change should be exempt from the code standards and process.

Additional comments or questions

If you have any further comments or questions for the reviewer them please add them here.

@github-actions github-actions bot temporarily deployed to pr-413 October 12, 2023 09:17 Inactive
@github-actions github-actions bot temporarily deployed to pr-413 October 12, 2023 09:48 Inactive
@github-actions github-actions bot temporarily deployed to pr-413 October 12, 2023 09:53 Inactive
@github-actions github-actions bot temporarily deployed to pr-413 October 12, 2023 10:00 Inactive
@github-actions github-actions bot temporarily deployed to pr-413 October 13, 2023 09:14 Destroyed
@kasperbirch1 kasperbirch1 changed the title Create environment for testing: DDFLSBP-192 Create environment for testing: DDFLSBP-192 (Align with Reservation Change) Oct 16, 2023
@github-actions github-actions bot temporarily deployed to pr-413 October 16, 2023 09:20 Destroyed
@github-actions github-actions bot temporarily deployed to pr-413 October 16, 2023 09:39 Destroyed
@github-actions github-actions bot temporarily deployed to pr-413 October 16, 2023 09:42 Destroyed
@kasperbirch1 kasperbirch1 changed the title Create environment for testing: DDFLSBP-192 (Align with Reservation Change) Create environment for testing: DDFLSBP-192 (Align Reservation Change) Oct 16, 2023
@github-actions github-actions bot temporarily deployed to pr-413 October 16, 2023 11:10 Destroyed
@kasperbirch1 kasperbirch1 force-pushed the DDFLSBP-192-samlesag-ensretning-af-skift-af-interesseperiode-og-afhentningssted-pa-reserveringer branch from 711fdfd to 6883d4c Compare October 16, 2023 11:15
@github-actions github-actions bot temporarily deployed to pr-413 October 16, 2023 11:16 Destroyed
@kasperbirch1 kasperbirch1 force-pushed the DDFLSBP-192-samlesag-ensretning-af-skift-af-interesseperiode-og-afhentningssted-pa-reserveringer branch from 6883d4c to ce91cb3 Compare October 16, 2023 11:26
@github-actions github-actions bot temporarily deployed to pr-413 October 16, 2023 11:27 Destroyed
@kasperbirch1 kasperbirch1 force-pushed the DDFLSBP-192-samlesag-ensretning-af-skift-af-interesseperiode-og-afhentningssted-pa-reserveringer branch from ce91cb3 to c4bf652 Compare October 16, 2023 11:35
@github-actions github-actions bot temporarily deployed to pr-413 October 16, 2023 11:36 Destroyed
@github-actions github-actions bot temporarily deployed to pr-413 October 16, 2023 11:49 Destroyed
@github-actions github-actions bot temporarily deployed to pr-413 October 16, 2023 12:05 Destroyed
@github-actions github-actions bot temporarily deployed to pr-413 October 16, 2023 12:16 Destroyed
@kasperbirch1 kasperbirch1 force-pushed the DDFLSBP-192-samlesag-ensretning-af-skift-af-interesseperiode-og-afhentningssted-pa-reserveringer branch from 882d30d to 0bb5fd6 Compare October 16, 2023 12:18
@github-actions github-actions bot temporarily deployed to pr-413 October 16, 2023 12:19 Destroyed
@Adamik10 Adamik10 self-requested a review October 17, 2023 09:03
Adamik10
Adamik10 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@Adamik10 Adamik10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice with updating the translation strings :))
Don't forget to change the dpl-react package link in composer.json back to danskernesdigitalebibliotek/dpl-react/releases/download/release-develop/dist.zip and update the lock file when all is approved and merged in dpl-react 😉

@kasperbirch1 kasperbirch1 force-pushed the DDFLSBP-192-samlesag-ensretning-af-skift-af-interesseperiode-og-afhentningssted-pa-reserveringer branch from 0bb5fd6 to 1b1225e Compare October 17, 2023 11:32
@github-actions github-actions bot temporarily deployed to pr-413 October 17, 2023 11:33 Destroyed
@kasperbirch1 kasperbirch1 merged commit 23d4c8c into develop Oct 17, 2023
15 checks passed
@kasperbirch1 kasperbirch1 deleted the DDFLSBP-192-samlesag-ensretning-af-skift-af-interesseperiode-og-afhentningssted-pa-reserveringer branch October 17, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adamik10 Adamik10 Adamik10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kasperbirch1 @Adamik10 @spaceo