Replace min-height with height in dialog--sidebar

The previous use of `min-height` led to an unexpected layout issue, preventing the branch list from displaying correctly and making scrolling impossible. - Added additional libraries to `OpeningHoursSidebar` to improve Chromatic's ability to identify unexpected UI changes
danskernesdigitalebibliotek · Jan 24, 2025 · 79be655 · 79be655
1 parent e892821
commit 79be655
Show file tree

Hide file tree

Showing 3 changed files with 87 additions and 2 deletions.
diff --git a/src/stories/Library/dialog/dialog.scss b/src/stories/Library/dialog/dialog.scss
@@ -23,7 +23,7 @@
   // Apply custom
   background-color: $color__global-primary;
   position: fixed;
-  min-height: 100dvh;
+  height: 100dvh;
   width: 100%;
   left: auto;
 

diff --git a/src/stories/Library/opening-hours-sidebar/OpeningHoursSidebar.stories.tsx b/src/stories/Library/opening-hours-sidebar/OpeningHoursSidebar.stories.tsx
@@ -45,7 +45,7 @@ export default {
 const Template: StoryFn<typeof OpeningHoursSidebar> = (args) => {
   return (
     <div className="storybook-dialog-sidebar">
-      <OpeningHoursSidebar {...args} />;
+      <OpeningHoursSidebar {...args} />
     </div>
   );
 };

diff --git a/src/stories/Library/opening-hours-sidebar/opening-hours-libraries-data.ts b/src/stories/Library/opening-hours-sidebar/opening-hours-libraries-data.ts
@@ -25,6 +25,91 @@ const defaultLibraries = [
     name: "Blågårdens Bibliotek",
     openingHoursData,
   },
+  {
+    id: "5",
+    name: "Brønshøj Bibliotek",
+    openingHoursData,
+  },
+  {
+    id: "6",
+    name: "Christianshavns Bibliotek",
+    openingHoursData,
+  },
+  {
+    id: "7",
+    name: "Husum Bibliotek",
+    openingHoursData,
+  },
+  {
+    id: "8",
+    name: "Islands Brygge Bibliotek",
+    openingHoursData,
+  },
+  {
+    id: "9",
+    name: "Kildevæld Kulturcenter",
+    openingHoursData,
+  },
+  {
+    id: "10",
+    name: "Kulturstationen Vanløse",
+    openingHoursData,
+  },
+  {
+    id: "11",
+    name: "Nørrebro Bibliotek",
+    openingHoursData,
+  },
+  {
+    id: "12",
+    name: "Solvang Bibliotek",
+    openingHoursData,
+  },
+  {
+    id: "13",
+    name: "Sundby Bibliotek",
+    openingHoursData,
+  },
+  {
+    id: "14",
+    name: "Sydhavnens Bibliotek",
+    openingHoursData,
+  },
+  {
+    id: "15",
+    name: "Tingbjerg Bibliotek\\Kulturhus",
+    openingHoursData,
+  },
+  {
+    id: "16",
+    name: "Valby Bibliotek",
+    openingHoursData,
+  },
+  {
+    id: "17",
+    name: "Vesterbro Bibliotek og Kulturhus",
+    openingHoursData,
+  },
+  {
+    id: "18",
+    name: "Vigerslev Bibliotek",
+    openingHoursData,
+  },
+  {
+    id: "19",
+    name: "Øbro Jagtvej Bibliotek",
+    openingHoursData,
+  },
+  {
+    id: "20",
+    name: "Ørestad Bibliotek",
+    openingHoursData,
+  },
+  {
+    id: "21",
+    name: "Østerbro Bibliotek",
+    openingHoursData,
+  },
 ];
 
 export default defaultLibraries;