DDFFORM 69 #595
Merged
DDFFORM 69 #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LasseStaus
force-pushed
the
DDFFORM-69
branch
2 times, most recently
from
2103a5a to
6bd0d9d
Compare
kasperg
approved these changes
Apr 19, 2024
src/stories/Library/filtered-event-list/filtered-event-list.scss
Outdated
Show resolved
Hide resolved
src/stories/Library/filtered-event-list/FilteredEventListData.tsx
Outdated
Show resolved
Hide resolved
This adds the markup for the new component filteredEventList. Styling & JS depends on other commits. DDFFORM-69
DDFFORM-69
This commit updates the show-more js file which can be used for multiple components that require a fold in/ fold out functionality. The refactor aims to keep the existing funtionality aswell as add to it. This includes - Make it possible to select whether the list-button show be visible or not after expanding a list. - Determine how many list items show be initially shown, with a fallback of the amount of list-elements if not specified. - Automatically hide the button if there are no more elements to show than specified through the - Automatically handle aria-control linking between list/button. - Moved some data-attributes to other elements as well as renaming some variables. If you see any improvements to something or another feature that would be nice feel free to comment. Currently it is only possible to use this, if the button/list exists in the same wrapper. This could be change later if relevant but currently it isn't. Updated .md file also to reflect these changes. DDFFORM-69
This updates the logic for the taglist with the new refactored show-more logic. DDFFORM-69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
DDFFORM-69
This PR depends on a PR in the design system : danskernesdigitalebibliotek/dpl-cms#1002
Description
This PR adds the markup for the new component "Filtered event list".
show-more.jslogic with more functionality for controlling wheter a button should be displayed or not after a list is expanded. Moved some namings/data-attributes around.Comment on this logic and test it out please.
show-more.jslogic. Currently this should only be<TagList/>. If you think this is incorrect comment it.Chromatic is left unaccepted on purpose to see changes. Will accept once approved.
Once again, we see weird chromatic changes that should not be associated with these changes.
Screenshot of the result