DDFBRA-225 - Use svh height to ensure consistent modal layout
#809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperbirch1
force-pushed
the
DDFBRA-225-mobilvisning-abningstidsmodal-kan-ikke-lukkes
branch
from
28e40f3 to
1b565ff
Compare
Ensures a more consistent layout on mobile devices by accounting for dynamic changes in viewport height caused by browser UI elements, such as the address bar in Chrome.
Ensures the `dvh` value correctly adjusts the modal when scrolling on mobile browsers with disappearing address bars
kasperbirch1
force-pushed
the
DDFBRA-225-mobilvisning-abningstidsmodal-kan-ikke-lukkes
branch
from
1b565ff to
92a7cd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFBRA-225
Description
Ensures a more consistent layout on mobile devices by accounting for dynamic changes in viewport height caused by browser UI elements, such as the address bar in Chrome.
Test
https://varnish.pr-1877.dpl-cms.dplplat01.dpl.reload.dk/
ScreenRecording_12-18-2024.13-45-24_1.mov