Seperate versions between moduletest and main #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperg
requested changes
Aug 15, 2024
Comment on lines
38
to
48
| function getWebmasterDplCmsRelease { | ||
| local wmRelease | ||
| wmRelease=$(yq eval ".sites.${1}.webmaster-cms-version" "${2}") | ||
| if [[ "${wmRelease}" == "null" ]]; then | ||
| echo "" | ||
| return | ||
| fi | ||
|
|
||
| echo "${wmRelease}" | ||
| return | ||
| } |
There was a problem hiding this comment.
How will the caller syncEnvRepo handle an empty string as a response?
I am no expert in Bash but I wonder if it would be preferable if the function failed entirely if this is missing - or alternately used releaseTag with a message explaining that no information about a webmaster specific function could be found.
There was a problem hiding this comment.
This is a copy of the already tried and tested function that finds the release for main. If there is an empty string that's what's returned. It then defaults to the latest image.
ITViking
force-pushed
the
seperate-versions-between-moduletest-and-main
branch
from
6f1abce to
91fc5bc
Compare
|
I've retested it. Main and moduletest of canary is now running seperate versions: 33.0 and 32.1 respectively |
kasperg
approved these changes
Aug 21, 2024
added 5 commits
August 28, 2024 14:00
ITViking
force-pushed
the
seperate-versions-between-moduletest-and-main
branch
from
3515a73 to
074a813
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR allows us to have seperate versions on WM and prod sites
Should this be tested by the reviewer and how?
Read it through and test it on canary
Any specific requests for how the PR should be reviewed?
What are the relevant tickets?
https://reload.atlassian.net/jira/software/c/projects/DDFDRIFT/boards/464?selectedIssue=DDFDRIFT-154