Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial take on ADR reasoning the move from Azure managed db to in-cl… #583
base: main
Are you sure you want to change the base?
initial take on ADR reasoning the move from Azure managed db to in-cl… #583
Changes from 8 commits
1286f5c
417b2cb
60115b4
03e079f
3147881
2dfa856
5c5c8be
f3a0d73
927ac36
9c9d30c
a3b7a25
0141a55
18143b1
e3553f3
94f7fe0
575f69a
4bf0ad5
fceead2
ab452c4
8f43795
129c0fe
b5d558f
16cf0ef
dafb7c2
856ab92
7d08972
177eefe
20a03bd
319659e
ff1f105
a06317b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have had bad experiences but is this really one of them? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In part this is an attempt at shorten the experience with Azure Support. I do believe on of the issues with the Support is that we have to wait for them to have time to help us. In contrast, having the databases in-cluster, will allow immediate troubleshooting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a hypothetical. I think it is worth moving the mention of the misconfigured database into the bullet above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The server was configured to match that of much more powerful server than the one we have, so I would say they definitely misconfigured our server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it the first list going over the bad experiences we've had?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all this can be reduced to something like "Continual use of managed database product".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the ADR's are to be readable to non-technical staff, the suggested one-liner leaves out crucial information, that would enable non-technical staff to understand the trade offs. Leaving it as is, elaborates on some of the points for using a managed database.