Skip to content

Commit

Permalink
Merge pull request #1358 from danskernesdigitalebibliotek/DDFLSBP-690…
Browse files Browse the repository at this point in the history
…-remove-null-from-pickup-branch

Updated the required check to display empty string instead of null.
  • Loading branch information
Adamik10 authored Aug 28, 2024
2 parents 7e43bd7 + a18e89b commit de95645
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/apps/patron-page/util/BranchesDropdown.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const BranchesDropdown: FC<BranchesDropdownProps> = ({
htmlFor="branches-dropdown"
className="text-body-medium-medium mt-32 mb-8"
>
{`${t("pickupBranchesDropdownLabelText")}${required ? "*" : null}`}
{`${t("pickupBranchesDropdownLabelText")}${required ? " *" : ""}`}
</label>
<div
className={clsx(`dropdown mt-8 ${classNames || ""}`, [
Expand Down
2 changes: 1 addition & 1 deletion src/components/atoms/input/TextInput.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const TextInput: FC<TextInputProps> = ({
{ "dpl-input--invalid": !!validation }
])}
>
<label htmlFor={id}>{required ? `${label}*` : label}</label>
<label htmlFor={id}>{required ? `${label} *` : label}</label>
<input
className="text-body-medium-medium"
required={required}
Expand Down

0 comments on commit de95645

Please sign in to comment.