Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a loading reserve button on material page until all data is loaded #1100

Merged

Conversation

Adamik10
Copy link
Contributor

@Adamik10 Adamik10 commented Apr 9, 2024

Link to issue

https://reload.atlassian.net/browse/DDFLSBP-519

Description

Show a loading reserve button on material page until all data is loaded. We were waiting for patron data to load, but not for material availability data, which was being loaded inside a custom React hook. React query caching handling is used in our advantage here in order to extract whether the loading state inside the hook.

Screenshot of the result

Additional comments or questions

Copy link
Contributor

@Dresse Dresse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Adamik10 Adamik10 merged commit 45b0ad9 into release/brahma-14 Apr 10, 2024
20 checks passed
@Adamik10 Adamik10 deleted the add-initial-loading-state-to-reservation-button branch April 10, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants