Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle opening hours with end_time "00:00" #1357

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kasperbirch1
Copy link
Contributor

Link to issue

https://reload.atlassian.net/browse/DDFFORM-818

Description

This pull request addresses the issue of handling opening hours where the end_time is "00:00". This change is in response to the modifications made in danskernesdigitalebibliotek/dpl-cms#1249.

"00:00" is an invalid time for FullCalendar because it is technically the first time on a day. Therefore, `endTimes` that are "00:00" should be converted to "24:00".

We also want to allow opening hours from "00:00" to "00:00" without disabling the save button.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants