DDFLSBP-637 - Change advanced search input element into and img element #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Input elements with type "image" should only be used for making graphical submit buttons.
as img elements are non interactive. I have instead opted for keeping the input element and assigned the role of "combobox" and giving it a aria-controls property, which are set to the element that is showing the dropdown.
approach, as it showed the input field as an actual input field. Instead I have opted to use a Button, containing an image element.
kasperbirch1
reviewed
Aug 7, 2024
| /> | ||
| aria-controls="search-header-dropdown" | ||
| > | ||
| <img src={expandIcon} alt={t("searchHeaderDropdownText")} /> |
There was a problem hiding this comment.
I believe the alt text should be empty. There is already an explanatory aria-label on the button itself, and the icon is purely decorative.
Please also remember to update the design system:
https://github.com/danskernesdigitalebibliotek/dpl-design-system/blob/61b0e63f93d93328401a3e6b8e0f18089a7d4be7/src/stories/Blocks/header/Header.tsx#L112
There was a problem hiding this comment.
That makes sense. I have set the alt tab to empty now.
I will look into updating the design system 👍
There was a problem hiding this comment.
I have updated dpl-design-system: danskernesdigitalebibliotek/dpl-design-system#701
I just added the aria-label. Do you think that is enough, or are more changes needed here?
kasperbirch1
approved these changes
Aug 7, 2024
purposes, and therefore the aria-label should be enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-637
Description
Changed the advanced-search input element into a button element containing an image element.
Screenshot of the result
Additional comments or questions
This PR has a sister PR here: danskernesdigitalebibliotek/dpl-design-system#701