Release 2024.38.1 #1444
Merged
Release 2024.38.1 #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation will return undefined if the creators array is empty. This causes other functions which expect a string (which is what TypeScript assumes) to fail. Add a return type to the function to assert the intention of the function. We could also have allowed it to return undefined if the creators array is empty but that seems to be against the naming of the function, creatorsToString. Add a check to handle single array and empty creators array separately. If there are no creators then return an empty string.
…f-no-creators Ensure creatorsToString() always returns a string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.