-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2024.43.0 #1500
Merged
Release 2024.43.0 #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry for the big blob of changes. Went with the flow and changed a lot at the same time.
Since facets have a new `type` property we need to add it the the tested data. We should probably use the new enum in the future instead of plain string comparison.
Series - new structure with members and numberInseries Facet - has introduced a type property Access - has changed into objects with typenames
Since series changed data structure the fixture needs to be changed as well.
Assumptions of how the functionality should work with new series structure was wrong
Was formatted wrongly in a former hugh search/replace action.
The current implementation will return undefined if the creators array is empty. This causes other functions which expect a string (which is what TypeScript assumes) to fail. Add a return type to the function to assert the intention of the function. We could also have allowed it to return undefined if the creators array is empty but that seems to be against the naming of the function, creatorsToString. Add a check to handle single array and empty creators array separately. If there are no creators then return an empty string.
Bumps [focus-trap-react](https://github.com/focus-trap/focus-trap-react) from 10.2.3 to 10.3.0. - [Release notes](https://github.com/focus-trap/focus-trap-react/releases) - [Changelog](https://github.com/focus-trap/focus-trap-react/blob/master/CHANGELOG.md) - [Commits](focus-trap/focus-trap-react@v10.2.3...v10.3.0) --- updated-dependencies: - dependency-name: focus-trap-react dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.3.5 to 18.3.8. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [sass](https://github.com/sass/dart-sass) from 1.78.0 to 1.79.3. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.78.0...1.79.3) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [caniuse-lite](https://github.com/browserslist/caniuse-lite) from 1.0.30001660 to 1.0.30001662. - [Commits](browserslist/caniuse-lite@1.0.30001660...1.0.30001662) --- updated-dependencies: - dependency-name: caniuse-lite dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@cypress/code-coverage](https://github.com/cypress-io/code-coverage) from 3.12.48 to 3.13.1. - [Release notes](https://github.com/cypress-io/code-coverage/releases) - [Changelog](https://github.com/cypress-io/code-coverage/blob/master/.releaserc) - [Commits](cypress-io/code-coverage@v3.12.48...v3.13.1) --- updated-dependencies: - dependency-name: "@cypress/code-coverage" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [nyc](https://github.com/istanbuljs/nyc) from 17.0.0 to 17.1.0. - [Release notes](https://github.com/istanbuljs/nyc/releases) - [Changelog](https://github.com/istanbuljs/nyc/blob/main/CHANGELOG.md) - [Commits](istanbuljs/nyc@nyc-v17.0.0...nyc-v17.1.0) --- updated-dependencies: - dependency-name: nyc dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [stylelint-scss](https://github.com/stylelint-scss/stylelint-scss) from 6.6.0 to 6.7.0. - [Release notes](https://github.com/stylelint-scss/stylelint-scss/releases) - [Changelog](https://github.com/stylelint-scss/stylelint-scss/blob/master/CHANGELOG.md) - [Commits](stylelint-scss/stylelint-scss@v6.6.0...v6.7.0) --- updated-dependencies: - dependency-name: stylelint-scss dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
The values we were using before aren't valid anymore, because the FBI spec changed all the enum values to be IN CAPS, and simple search filters don't accept that.
So that we don't keep the filters from our previous, unrelated search.
This one includes a dot "." - 8.660345-46.
Bumps the storybook group with 1 update in the / directory: [@storybook/react-webpack5](https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/react-webpack5). Updates `@storybook/react-webpack5` from 8.3.3 to 8.3.6 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v8.3.6/code/frameworks/react-webpack5) --- updated-dependencies: - dependency-name: "@storybook/react-webpack5" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: storybook ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@vitest/coverage-istanbul](https://github.com/vitest-dev/vitest/tree/HEAD/packages/coverage-istanbul) from 2.1.2 to 2.1.3. - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Commits](https://github.com/vitest-dev/vitest/commits/v2.1.3/packages/coverage-istanbul) --- updated-dependencies: - dependency-name: "@vitest/coverage-istanbul" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [stylelint-scss](https://github.com/stylelint-scss/stylelint-scss) from 6.7.0 to 6.8.1. - [Release notes](https://github.com/stylelint-scss/stylelint-scss/releases) - [Changelog](https://github.com/stylelint-scss/stylelint-scss/blob/master/CHANGELOG.md) - [Commits](stylelint-scss/stylelint-scss@v6.7.0...v6.8.1) --- updated-dependencies: - dependency-name: stylelint-scss dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [caniuse-lite](https://github.com/browserslist/caniuse-lite) from 1.0.30001667 to 1.0.30001669. - [Commits](browserslist/caniuse-lite@1.0.30001667...1.0.30001669) --- updated-dependencies: - dependency-name: caniuse-lite dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [sass](https://github.com/sass/dart-sass) from 1.79.4 to 1.80.3. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.79.4...1.80.3) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…npm_and_yarn/babel-26869f8ab1 Bump the babel group with 2 updates
…npm_and_yarn/eslint-plugin-react-hooks-5.0.0 Bump eslint-plugin-react-hooks from 4.6.2 to 5.0.0
…npm_and_yarn/types/react-dom-18.3.1 Bump @types/react-dom from 18.3.0 to 18.3.1
…npm_and_yarn/storybook-80533eea89 Bump @storybook/react-webpack5 from 8.3.3 to 8.3.6 in the storybook group across 1 directory
…npm_and_yarn/vitest/coverage-istanbul-2.1.3 Bump @vitest/coverage-istanbul from 2.1.2 to 2.1.3
…npm_and_yarn/stylelint-scss-6.8.1 Bump stylelint-scss from 6.7.0 to 6.8.1
Bumps [@chromatic-com/storybook](https://github.com/chromaui/addon-visual-tests) from 1.9.0 to 2.0.2. - [Release notes](https://github.com/chromaui/addon-visual-tests/releases) - [Changelog](https://github.com/chromaui/addon-visual-tests/blob/main/CHANGELOG.md) - [Commits](chromaui/addon-visual-tests@v1.9.0...v2.0.2) --- updated-dependencies: - dependency-name: "@chromatic-com/storybook" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…npm_and_yarn/caniuse-lite-1.0.30001669 Bump caniuse-lite from 1.0.30001667 to 1.0.30001669
…npm_and_yarn/sass-1.80.3 Bump sass from 1.79.4 to 1.80.3
Bumps [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/cli) from 8.3.3 to 8.3.6. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v8.3.6/code/lib/cli) --- updated-dependencies: - dependency-name: storybook dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…npm_and_yarn/storybook-8.3.6 Bump storybook from 8.3.3 to 8.3.6
…npm_and_yarn/chromatic-com/storybook-2.0.2 Bump @chromatic-com/storybook from 1.9.0 to 2.0.2
…fejl-fbs-vaerker-fra-naxos Ddfbra 101 fejl fbs vaerker fra naxos
…filtrering-sker-ikke Ddfbra 100 filtrering sker ikke
Since `useGetHoldings` serves multiple purposes, we need the flexibility to select a specific blacklist. For example, the message displaying the number of materials in the library should only use the `"availability"` blacklist. I updated the code to ensure that the blacklist is always defined as `"availability" | "pickup" | "both"`, making the decision explicit and improving code readability.
…-peg-pa-fb-is-aendrede-api New FBI API changes
After reviewing my changes, I realized the code remains functionally the same. While my version was easier to read when I was understanding the code, there's no reason to redo it without functional improvements.
…the-library-has-xx-copies-should-be-controlled-by-blacklist-from-availability DDFHER-100 - Refactor `getBlacklistedQueryArgs` for specific blacklist to manage materials count
…em-2024.43.0 Use release 2024.43.0 of design system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.