Release 2024.44.0 #1518
Merged
Release 2024.44.0 #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the `sortByDueDate` function to handle cases where the loan does not have a due date and now using `dayjs` for date manipulation instead of the native Date object. Previously, the code used the current date as a fallback, causing inconsistent sorting results. The new logic assigns 'Infinity' to loans without a due date, ensuring they always appear at the bottom of the list.
The `useLoans` hook should not handle the sorting of loans. - Moved `sortByDueDate` to a helper function to maintain separation of concerns. Used `lodash` to prevent modification of the original array. - Added `sortLoansByIsRenewableThenDueDate` to enable proper sorting of loans on the dashboard. **Note:** The `stackedMaterialsDueDatesFbs` function will be removed in the next commit.
Based on the previous commit, `stackedMaterialsDueDates` should not be part of `useLoans`. The purpose of `useLoans` is strictly to provide a list of loans.
…or loans The `useLoans` hook already provides a combined list of all loans (Publizon and FBS), making the `.concat` operation redundant.
Refactored the sorting logic by separating the `sortByRenewable` function from `sortLoansByIsRenewableThenDueDate`. The new implementation composes the `sortByRenewable` and `sortByDueDate` functions for clarity and to avoid duplication.
Updated the filter logic to explicitly check for both undefined and null dueDate values. This ensures that both cases are correctly excluded from the resulting list of due dates.
This change simplifies the code and ensures loans with the same due date but different times will be sorted accurately if needed.
DDFHER-89 - Ensure consistent sorting for loans
Somehow Dependabot will not make this update. I have run `yarn add downshift@latest` and tested it locally without problems.
@reach/alert now uses named exports - even though the documentation on reach.tech has not been updated for it. https://github.com/reach/reach-ui/releases/tag/v0.18.0
Bumps the babel group with 4 updates: [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core), [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env), [@babel/preset-react](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-react) and [@babel/preset-typescript](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-typescript). Updates `@babel/core` from 7.25.8 to 7.26.0 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.26.0/packages/babel-core) Updates `@babel/preset-env` from 7.25.8 to 7.26.0 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.26.0/packages/babel-preset-env) Updates `@babel/preset-react` from 7.25.7 to 7.25.9 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.25.9/packages/babel-preset-react) Updates `@babel/preset-typescript` from 7.25.7 to 7.26.0 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.26.0/packages/babel-preset-typescript) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: babel - dependency-name: "@babel/preset-env" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: babel - dependency-name: "@babel/preset-react" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: babel - dependency-name: "@babel/preset-typescript" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: babel ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [caniuse-lite](https://github.com/browserslist/caniuse-lite) from 1.0.30001669 to 1.0.30001673. - [Commits](browserslist/caniuse-lite@1.0.30001669...1.0.30001673) --- updated-dependencies: - dependency-name: caniuse-lite dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@namics/stylelint-bem](https://github.com/merkle-open/stylelint-bem) from 10.0.1 to 10.1.0. - [Release notes](https://github.com/merkle-open/stylelint-bem/releases) - [Changelog](https://github.com/merkle-open/stylelint-bem/blob/master/CHANGELOG.md) - [Commits](merkle-open/stylelint-bem@10.0.1...10.1.0) --- updated-dependencies: - dependency-name: "@namics/stylelint-bem" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.3.11 to 18.3.12. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react) from 7.37.1 to 7.37.2. - [Release notes](https://github.com/jsx-eslint/eslint-plugin-react/releases) - [Changelog](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](jsx-eslint/eslint-plugin-react@v7.37.1...v7.37.2) --- updated-dependencies: - dependency-name: eslint-plugin-react dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…npm_and_yarn/babel-0e46db8264 Bump the babel group with 4 updates
…npm_and_yarn/caniuse-lite-1.0.30001673 Bump caniuse-lite from 1.0.30001669 to 1.0.30001673
…npm_and_yarn/namics/stylelint-bem-10.1.0 Bump @namics/stylelint-bem from 10.0.1 to 10.1.0
…npm_and_yarn/types/react-18.3.12 Bump @types/react from 18.3.11 to 18.3.12
…npm_and_yarn/eslint-plugin-react-7.37.2 Bump eslint-plugin-react from 7.37.1 to 7.37.2
…-eslint-plugin-jsx-a11y Upgrade eslint-plugin-jsx-a11y
…-upgrade-reach-alert Upgrade @reach/alert
…-upgrade-unfetch Upgrade unfetch
…update-downshift DDFHER-106 - Updated `downshift` to version 9
Bumps [@chromatic-com/storybook](https://github.com/chromaui/addon-visual-tests) from 2.0.2 to 3.1.0. - [Release notes](https://github.com/chromaui/addon-visual-tests/releases) - [Changelog](https://github.com/chromaui/addon-visual-tests/blob/main/CHANGELOG.md) - [Commits](chromaui/addon-visual-tests@v2.0.2...v3.1.0) --- updated-dependencies: - dependency-name: "@chromatic-com/storybook" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [sass](https://github.com/sass/dart-sass) from 1.80.3 to 1.80.4. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.80.3...1.80.4) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…npm_and_yarn/chromatic-com/storybook-3.1.0 Bump @chromatic-com/storybook from 2.0.2 to 3.1.0
…npm_and_yarn/sass-1.80.4 Bump sass from 1.80.3 to 1.80.4
…npm_and_yarn/braces-3.0.3 Bump braces from 3.0.2 to 3.0.3
IntegrationFolder is now deprecated and the config file should instead rely on Testing Type-Specific Options https://docs.cypress.io/app/references/configuration#Testing-Type-Specific-Options
By default test isolation will be enabled in Cypress 12 and up, but out tests are not ready to run isolated yet. This should be prioritized in another task.
As Cypress 10 depricates the use of a native separate plugins file, we need to import it into the config
…upgrade-react-error-boundary Upgraded react-error-boundary
…upgrade-cypress Upgrade Cypress
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.7 to 6.6.0. - [Commits](indutny/elliptic@v6.5.7...v6.6.0) --- updated-dependencies: - dependency-name: elliptic dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…npm_and_yarn/elliptic-6.6.0 Bump elliptic from 6.5.7 to 6.6.0
…em-2024.44.0 Use release 2024.44.0 of design system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.