Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent double click on links (logout bug) #1633

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Adamik10
Copy link
Contributor

@Adamik10 Adamik10 commented Jan 8, 2025

Link to issue

https://reload.atlassian.net/browse/DDFBRA-331

Description

This PR adds loading state to Link component to prevent multiple clicks. Since the link is often used as a button in the interface, we needed a way to prevent multiple clicks on it before the action is fully carried out.

Screenshot of the result

Additional comments or questions

Since the link is often used as a button in the interface, we needed a way to prevent multiple clicks on it before the action is fully carried out.
Copy link
Contributor

@ThomasGross ThomasGross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this change is only use for this exact case, I don't think we should implement this change to every link on the site.

Consider creating another component or having this click lock as a conditional option passed down from props. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants