Add Validation for Phone Numbers #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adjusted the input type to 'tel' to enhance phone number input handling.
- Introduced new properties to `TextInput` to facilitate the validation of phone numbers, with specific enhancements:
- `pattern`: A regex implemented to match phone numbers originating from Denmark, Germany, and Greenland.
- `title`: used to display an error message in most browsers when the input does not adhere to the specified pattern.
- Employed the same text for the `placeholder` as the error message to inform users about the accepted phone number formats.
pattern:
* (\+45|0045)[0-9]{8}: Matches a Denmark phone number: country code +45, followed by 8 digits.
* (\+49|0049)[0-9]{7,11}: Matches a German phone number: country code +49, followed by between 7 and 11 digits.
* (\+299|00299)[0-9]{6}: Matches a Greenland phone number: country code +299, followed by 6 digits.
kasperbirch1
changed the title
kasperg
approved these changes
Oct 13, 2023
kasperbirch1
force-pushed
the
DDFLSBP-200-formvalidering-ingen-formvalidering-pa-felt-til-mobilnummer
branch
from
35a92d7 to
e6a043a
Compare
Ensure phone numbers are 6-15 characters in length and either numeric or start with a '+' This is to ensure that we can accept numbers from various sources while safeguarding against sending a number to the API that might cause an error.
kasperbirch1
force-pushed
the
DDFLSBP-200-formvalidering-ingen-formvalidering-pa-felt-til-mobilnummer
branch
from
e6a043a to
ff59a21
Compare
kasperbirch1
merged commit f00b79c
into
danskernesdigitalebibliotek:develop
10 checks passed
kasperbirch1
deleted the
DDFLSBP-200-formvalidering-ingen-formvalidering-pa-felt-til-mobilnummer
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-200
Description
Add Validation for Phone Numbers from Denmark, Germany, and Greenland
TextInputto facilitate the validation of phone numbers, with specific enhancements:pattern: A regex implemented to match phone numbers originating from Denmark, Germany, and Greenland.title: used to display an error message in most browsers when the input does not adhere to the specified pattern.placeholderas the error message to inform users about the accepted phone number formats.pattern:
Screenshot of the result
Skaermoptagelse.2023-10-11.kl.14.26.05.mov