Fix/user name in header #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can then use it other places, speficying the text line width..
I also introduced a loading state for the text line.
They both have to do with the same visual area. Also the user menu story looked messy before without the rest of the header to support it.
JacobArrow
reviewed
Oct 12, 2023
JacobArrow
reviewed
Oct 12, 2023
Adamik10
merged commit 6d2a7d6
into
danskernesdigitalebibliotek:develop
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-122
Description
PR adds the user's name under the "user" icon in the header if the user is logged in. I utilized a skeleton screen for the loading state too, which I made into a reusable component for short text skeletons.
It also restructures our (what previously used to be called) "menu" and "search-header" stories. These both work with the same visual real estate, so they now also live together in storybook under the new "Header" story in two understories - user menu & search. 🏆 🎉 🔥
Screenshot of the result
(previous story for reference:)
Checklist
Additional comments or questions
n/a