Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/2.1 partner #10

Merged
merged 13 commits into from
Dec 14, 2023
Merged

Feature/2.1 partner #10

merged 13 commits into from
Dec 14, 2023

Conversation

hsuifang
Copy link
Contributor

@hsuifang hsuifang commented Dec 3, 2023

找夥伴頁面列表頁面

Part

  • Banner
  • Partner List
  • SearchField (主要引用阿毛內容再調整)
  • SearchParamsList (顯示搜尋的參數）

API(partnerSaga)

@vercel Vercel
Copy link

vercel bot commented Dec 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
daodao-f2e ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2023 7:21am

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 3, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c5c428d
Status: ✅  Deploy successful!
Preview URL: https://a49c6650.daodao-notion-test.pages.dev
Branch Preview URL: https://feature-2-1-partner.daodao-notion-test.pages.dev

View logs

@hsuifang hsuifang requested a review from vincentxuu December 3, 2023 07:07
JohnsonMao
JohnsonMao reviewed Dec 8, 2023
View reviewed changes
Copy link
Contributor

@JohnsonMao JohnsonMao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

太驚訝了~ 後端 API 與 cloudflare-pages 都是你部屬的嗎
可惜在 Preview 時有 CORS 問題

components/Partner/SearchParamsList/index.jsx Outdated Show resolved Hide resolved
@hsuifang
Copy link
Contributor Author

太驚訝了~ 後端 API 與 cloudflare-pages 都是你部屬的嗎 可惜在 Preview 時有 CORS 問題

不是～ 那是原本就有的ＸＤＤＤ 只是我把它拿來用

@JohnsonMao JohnsonMao merged commit ab987bc into dev Dec 14, 2023
6 checks passed
@JohnsonMao JohnsonMao deleted the feature/2.1_partner branch December 14, 2023 14:00
@JohnsonMao JohnsonMao mentioned this pull request Jul 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnsonMao JohnsonMao JohnsonMao left review comments

@pepe1113 pepe1113 Awaiting requested review from pepe1113

@vincentxuu vincentxuu Awaiting requested review from vincentxuu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsuifang @JohnsonMao @whalekiller03