-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Background images #1057
Background images #1057
Conversation
This is great! I wanted to give you a quick heads-up that I'm currently in the process of getting v0.14 ready for release, and it's been quite a journey so far (take a look at #897). It might take a little while to review this PR and #1021. After we merge the new version, there might be some conflicts, but no worries! The underlying architecture is still quite similar, and I'm here to lend a hand in ironing out any kinks. Thank you for your contributions! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1057 +/- ##
==========================================
- Coverage 99.53% 99.51% -0.02%
==========================================
Files 69 70 +1
Lines 4044 4118 +74
==========================================
+ Hits 4025 4098 +73
- Misses 19 20 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great. It just needs a conflict resolve with the master
branch.
Merged master and resolved review comments |
Thank you for the resolve. I have merged this PR! |
Adds basic support for using background images