Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background images #1057

Merged
merged 8 commits into from
Oct 27, 2023
Merged

Conversation

anttileppa
Copy link
Contributor

Adds basic support for using background images

@daohoangson
Copy link
Owner

This is great!

I wanted to give you a quick heads-up that I'm currently in the process of getting v0.14 ready for release, and it's been quite a journey so far (take a look at #897). It might take a little while to review this PR and #1021. After we merge the new version, there might be some conflicts, but no worries! The underlying architecture is still quite similar, and I'm here to lend a hand in ironing out any kinks. Thank you for your contributions!

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (25d7213) 99.53% compared to head (568bb7c) 99.51%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1057      +/-   ##
==========================================
- Coverage   99.53%   99.51%   -0.02%     
==========================================
  Files          69       70       +1     
  Lines        4044     4118      +74     
==========================================
+ Hits         4025     4098      +73     
- Misses         19       20       +1     
Files Coverage Δ
...es/core/lib/src/internal/ops/style_background.dart 100.00% <100.00%> (ø)
packages/core/lib/src/core_widget_factory.dart 99.77% <91.66%> (-0.23%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@daohoangson daohoangson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great. It just needs a conflict resolve with the master branch.

packages/core/lib/src/core_widget_factory.dart Outdated Show resolved Hide resolved
packages/core/test/_.dart Outdated Show resolved Hide resolved
@anttileppa
Copy link
Contributor Author

Merged master and resolved review comments

@daohoangson daohoangson merged commit f48adbf into daohoangson:master Oct 27, 2023
@daohoangson
Copy link
Owner

Thank you for the resolve. I have merged this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants