Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS code signing issue during integration test #1370

Closed
wants to merge 6 commits into from

Conversation

daohoangson
Copy link
Owner

@daohoangson daohoangson commented Nov 14, 2024

Fastlane match created a temporary keychain successfully. Imported certificates (ours and Apple's) and private key OK. But somehow the code sign is not valid. Happened on both local env & GitHub Actions...

On local env, it works correctly with the login keychain (the default one).

So...

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.56%. Comparing base (0fa344e) to head (0c7e079).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1370   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files          79       79           
  Lines        4921     4921           
=======================================
  Hits         4801     4801           
  Misses        120      120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 14, 2024

@daohoangson daohoangson changed the title Fix iOS integration test Fix iOS code signing issue during integration test Nov 24, 2024
@daohoangson
Copy link
Owner Author

Nuking the certificate and re-generating provisioning profiles worked. Closing this PR.

@daohoangson daohoangson deleted the fix/integration-test-ios branch November 24, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant