Skip to content

Commit

Permalink
DAOS-16557 test: Add debug to NvmeEnospace ftest
Browse files Browse the repository at this point in the history
Integrate reviewers comments:
- Update param type
- Remove useless commented metrics

Quick-Functional: true
Test-tag: NvmeEnospace
Required-githooks: true

Signed-off-by: Cedric Koch-Hofer <[email protected]>
  • Loading branch information
kanard38 authored and knard38 committed Feb 3, 2025
1 parent 6445498 commit 115170b
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions src/tests/ftest/nvme/enospace.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,7 @@ def __init__(self, *args, **kwargs):
"engine_pool_vos_aggregation_epr_duration_max",
"engine_pool_vos_aggregation_epr_duration_mean",
"engine_pool_vos_aggregation_epr_duration_min",
# "engine_pool_vos_aggregation_epr_duration_samples",
"engine_pool_vos_aggregation_epr_duration_stddev",
# "engine_pool_vos_aggregation_epr_duration_sum",
# "engine_pool_vos_aggregation_epr_duration_sumsquares"
"engine_pool_vos_aggregation_epr_duration_stddev"
]
self.metric_names = self.space_metric_names + self.aggr_metric_names

Expand Down Expand Up @@ -98,7 +95,7 @@ def get_pool_space_metrics(self, pool, metrics):
"""Return the metrics on space usage of a given pool.
Args:
pool (object): target TestPool.
pool (TestPool): target TestPool.
metrics (dict): telemetry metrics.
Returns:
Expand Down Expand Up @@ -139,7 +136,7 @@ def get_pool_aggr_metrics(self, pool, metrics):
"""Return the metrics on aggregation counters and gauges.
Args:
pool (object): target TestPool.
pool (TestPool): target TestPool.
metrics (dict): telemetry metrics.
Returns:
Expand Down Expand Up @@ -327,6 +324,7 @@ def display_stats(self):

pool_aggr_metrics = self.get_pool_aggr_metrics(self.pool, metrics)
self.display_pool_aggregation(pool_aggr_metrics)
self.log.debug("")

def verify_enospace_log(self, log_file):
"""Function checking logs consistency.
Expand Down Expand Up @@ -375,7 +373,7 @@ def delete_all_containers(self, pool):
"""Delete all the containers of a given pool.
Args:
pool (object): target TestPool.
pool (TestPool): target TestPool.
"""
# List all the container
kwargs = {"pool": pool.uuid}
Expand Down

0 comments on commit 115170b

Please sign in to comment.